fix(s3-deployment): skip replacement pass when no source markers#37393
Open
garysassano wants to merge 3 commits intoaws:mainfrom
Open
fix(s3-deployment): skip replacement pass when no source markers#37393garysassano wants to merge 3 commits intoaws:mainfrom
garysassano wants to merge 3 commits intoaws:mainfrom
Conversation
github-actions
bot
added
bug
aws-cdk-automation
previously requested changes
Mar 29, 2026
garysassano
force-pushed
the
fix/s3-deployment-no-marker-fast-path
branch
from
eac2447 to
5ef34f9
Compare
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Contributor
|
|
||||||||||||||
Contributor
|
|
||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #37234.
Reason for this change
BucketDeploymentstill walks extracted files for marker replacement even when a source has no markers. That adds unnecessary work for deployments that have nothing to substitute.Description of changes
aws-s3-deploymenthandler after extraction when the current source has no markers.replace_markers()when the marker map is empty.Describe any new or updated permissions being added
No new or updated IAM permissions are required.
Description of how you validated changes
bash packages/@aws-cdk/custom-resource-handlers/test/aws-s3-deployment/bucket-deployment-handler/test.sh.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license